Add hhvm in the allowed failures #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeSimonson
force-pushed
the
travis-hhvm
branch
2 times, most recently
from
1f90c91
to
ca4fee3
Compare
|
We guarantee HHVM compat. Build is to be fixed instead |
|
As far as I could see here are our options The main problem is that travis comes with a super old version of hhvm. Then
|
mikeSimonson
force-pushed
the
travis-hhvm
branch
2 times, most recently
from
fd2da21
to
9dbf6ae
Compare
|
We should try enforcing trusty and a newer hhvm version, as attempted in
other patches
…On 9 Feb 2017 14:39, "mikeSimonson" ***@***.***> wrote:
@Ocramius <https://github.com/ocramius>
As far as I could see here are our options
The main problem is that travis comes with a super old version of hhvm.
We need to update it but it will require sudo.
Then
- Find the right combination of (hhvm.php7.all=1 and
hhvm.php7.builtins=1)
- Or use composer install --ignore-platform-reqs with hhvm but it will
maybe have some weird side effect in the dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakFDERmhueCHqbPRrs3zX03E4kgkOks5raxcegaJpZM4L8GOR>
.
|
mikeSimonson
force-pushed
the
travis-hhvm
branch
from
9dbf6ae
to
f506d42
Compare
|
Do you know the version of hhvm on travis in trusty ? |
|
IIRC 3.17
…On 9 Feb 2017 2:52 p.m., "mikeSimonson" ***@***.***> wrote:
Do you know the version of hhvm on travis in trusty ?
Aka recent enough for hhvm.php7.all=1 and hhvm.php7.builtins=1 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakD9QpifyAkX5yl3YeNP9Y_tZqI_gks5raxo2gaJpZM4L8GOR>
.
|
stof
reviewed
Feb 9, 2017
|
|
||
| script: | ||
| - vendor/bin/phpunit | ||
|
|
||
| after_script: | ||
| - if [[ $TRAVIS_PHP_VERSION != '7.0' ]] && [[ $TRAVIS_PHP_VERSION != 'hhvm' ]]; then wget https://scrutinizer-ci.com/ocular.phar && php ocular.phar code-coverage:upload --format=php-clover build/logs/clover.xml; fi | ||
| - if [ $TRAVIS_PHP_VERSION = '7.1' ] && [[ $TRAVIS_PHP_VERSION != 'hhvm' ]]; then wget https://scrutinizer-ci.com/ocular.phar && php ocular.phar code-coverage:upload --format=php-clover build/logs/clover.xml; fi |
There was a problem hiding this comment.
as you use a equality check, there is no need to keep the check for hhvm
| sudo apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 0x5a16e7281be7a449 | ||
| sudo add-apt-repository "deb http://dl.hhvm.com/ubuntu $(lsb_release -sc) main" | ||
| sudo apt-get update | ||
| sudo apt-get install hhvm |
|
We decided to drop HHVM and removed it on #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.