Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Strict types, native parameter & return types #192

Merged
merged 14 commits into from Apr 30, 2019
Merged

[2.0] Strict types, native parameter & return types #192

merged 14 commits into from Apr 30, 2019

Conversation

jwage
Copy link
Member

@jwage jwage commented Apr 25, 2019 •
edited

Work originally started in #125

  • Bump dev-master branch alias to 2.0.x-dev
  • Require PHP 7.2
  • Upgrade PHPStan to 0.11
  • Increase PHPStan to Level 7
  • Add strict type hints everywhere
  • Remove some of the exclusion rules in phpcs.xml.dist
  • Sort packages in composer.json

@jwage jwage added this to the 2.0.0 milestone Apr 25, 2019
@jwage jwage force-pushed the types branch 3 times, most recently from 290e9f6 to 6a98b00 Compare April 29, 2019 19:52
@alcaeus alcaeus self-requested a review April 30, 2019 05:27
alcaeus
alcaeus reviewed Apr 30, 2019
View reviewed changes
composer.json Show resolved Hide resolved
lib/Doctrine/Common/Collections/Collection.php Outdated Show resolved Hide resolved
lib/Doctrine/Common/Collections/Criteria.php Outdated Show resolved Hide resolved
lib/Doctrine/Common/Collections/Expr/Comparison.php Outdated Show resolved Hide resolved
lib/Doctrine/Common/Collections/ExpressionBuilder.php Outdated Show resolved Hide resolved
lib/Doctrine/Common/Collections/ExpressionBuilder.php Outdated Show resolved Hide resolved
@ostrolucky ostrolucky assigned ostrolucky and unassigned ostrolucky Apr 30, 2019
@ostrolucky ostrolucky self-requested a review April 30, 2019 08:00
@stof
Copy link
Member

stof commented Apr 30, 2019

should we add psalm annotations for generics for the offset types ?

@jwage jwage force-pushed the types branch 2 times, most recently from 49dcf2b to 7772e59 Compare April 30, 2019 15:51
@jwage
Copy link
Member Author

jwage commented Apr 30, 2019

@stof I am new to psalm. What does that look like? Do we have any examples in Doctrine already I can look at?

@stof
Copy link
Member

stof commented Apr 30, 2019

we do have enhanced psalm annotations in the Collection interface, making generic

@jwage jwage self-assigned this Apr 30, 2019
@jwage jwage merged commit 8ad3946 into master Apr 30, 2019
@jwage jwage deleted the types branch April 30, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus left review comments

@ostrolucky ostrolucky ostrolucky approved these changes

Assignees

@jwage jwage

Labels
BC break Enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jwage @stof @alcaeus @ostrolucky @Majkl578