Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Fix return type of Collection::key() #241

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

weirdan
Copy link
Contributor

@weirdan weirdan commented Jun 21, 2020

This PR proposes to backport the annotation fix by @enumag from master to 1.6.x. There's no functionality changed, it just fixes the docblock that was wrong in the first place (as ArrayCollection::key() does return null on empty collections).

@greg0ire greg0ire merged commit 9672cf6 into doctrine:1.6.x Jun 22, 2020
@greg0ire greg0ire added this to the 1.6.6 milestone Jun 22, 2020
@greg0ire
Copy link
Member

Thanks @weirdan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants