Fix PHPStan #284
Merged
Fix PHPStan #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
added a commit
that referenced
this pull request
Sep 20, 2021
* Revert "Update Psalm and fix a few issues" This selectively reverts commit 6476b7e, now that PHPStan understands array-key. Note that the introduced return types are preserved because it should be that way whenever the #[ReturnTypeWillChange] attribute appears. Another big reason to revert this is that the phpdoc for offsetSet is wrong, it should have been TKey|null, not just TKey. * Merge pull request #284 from derrabus/bump/phpstan Fix PHPStan Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.