Admit no prefix as getter #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an alternative to reflection or closure hacking to properly get the private property whenever not using `getXXX()` `isXXX()` accessors, just added blank prefix '' to call DDD oriented notation (ex. `id()` ) Is adverted to who want to use this in a future, that if the method returns a valueObject, to use ::CONTAINS operator that casts to string, although the VO must be stringable
|
Interesting addition prevent classic getter names. Can you please also extend the tests for this naming? |
|
Please fix the issues listed in the coding standards results of the build. |
|
Looks great. Please adapt your 2 last commit message as described in our contribution guideline. https://www.doctrine-project.org/contribute/index.html#working-on-topic-branches |
Added a test for using blank accessor ('id' instead 'getId')
jorge-ruukfy
force-pushed
the
jorge-ruukfy-patch-1
branch
from
2b04a75
to
597892c
Compare
SenseException
previously approved these changes
Dec 27, 2021
|
Do we consider this to be a bugfix? Otherwise, we should target 1.7.x, shouldn't we? |
SenseException
dismissed
their stale review
This is considered a feature and needs to be merged into the next unreleased version branch
|
You're right. This is a feature. |
derrabus
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to reflection or closure hacking to properly get the private property whenever not using
getXXX()isXXX()accessors,just added blank prefix '' to call DDD oriented notation (ex.
id())Is adverted to who want to use this in a future, that if the method returns a valueObject, to use ::CONTAINS operator that casts to string, although the VO must be stringable