Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PHPStan level #290

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Bump PHPStan level #290

merged 1 commit into from
Nov 3, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 1, 2021

This PR bumps the PHPStan level to 8 and fixes some issues found on the way.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you switched to tabs on the doctrine/persistence PR but not on this one, is it deliberate?

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah actually it was just for the baseline. This should be fine.

@greg0ire greg0ire added this to the 1.6.9 milestone Nov 3, 2021
@greg0ire greg0ire merged commit 42a111a into doctrine:1.6.x Nov 3, 2021
@greg0ire
Copy link
Member

greg0ire commented Nov 3, 2021

Thanks @derrabus !

@derrabus derrabus deleted the bump/phpstan-level branch November 3, 2021 17:26
@derrabus
Copy link
Member Author

derrabus commented Nov 3, 2021

I noticed that you switched to tabs on the doctrine/persistence PR but not on this one, is it deliberate?

I have let PHPStan regenerate the baseline. I don't think we should edit that file manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants