Extract read-only part of Collection #322
Conversation
greg0ire
force-pushed
the
readable-collection
branch
2 times, most recently
from
7c5b2bf
to
7126702
Compare
| * | ||
| * @psalm-param TMaybeContained $element | ||
| * | ||
| * @psalm-return (TMaybeContained is T ? TKey|false : false) |
There was a problem hiding this comment.
If I don't copy/paste this here, I get
ERROR: InvalidReturnType - lib/Doctrine/Common/Collections/ArrayCollection.php:261:21 - The declared return type '(TKey:Doctrine\Common\Collections\ReadableCollection as array-key)|false' for Doctrine\Common\Collections\ArrayCollection::indexOf is incorrect, got '(TKey:Doctrine\Common\Collections\ArrayCollection as array-key)|false' (see https://psalm.dev/011)
public function indexOf($element)
from psalm, not sure why
There was a problem hiding this comment.
I'd have to spend a bit more time looking to be sure, but I'm guessing that's probably vimeo/psalm#7553. Docblock inheritance and templates don't play well with one another in Psalm, probably due to the way TKey on ReadableCollection is a different type from TKey on ArrayCollection and the docblock inheritance isn't automatically translating it based on the @implements/@extends on the class/interface declaration.
greg0ire
force-pushed
the
readable-collection
branch
from
bf62301
to
f319e40
Compare
|
🤦 how did I not see that? Thanks for pointing it out! |
|
Ah that would be because the build is 12 minutes old 🤔 |
|
Addressed in #327 |
Yeah, someone tested the PR locally, then suddenly run into this problem and tested it in this PR. I don't know who that was though 😇 |
This allows us to mark the extracted interface as covariant, thus allowing consumers to ensure through static analysis that a collection will not be altered in a way that would no longer make it a collection of items of a specific type. Closes doctrine#298
greg0ire
force-pushed
the
readable-collection
branch
from
b54894c
to
60f59ce
Compare
This allows us to mark the extracted interface as covariant, thus
allowing consumers to ensure through static analysis that a collection
will not be altered in a way that would no longer make it a collection
of items of a specific type.
Closes #298