Make Selectable template covariant #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, we express that one cannot use matching() to alter the templated type of a Selectable, which means that it is OK to pass a Selectable of a type to a method that accepts a Selectable of a parent type. The drawback is that it is no longer possible to use methods defined in Collection on an object that is returned by matching().
greg0ire
requested review from
stof,
derrabus,
malarzm,
SenseException and
beberlei
stof
approved these changes
Sep 26, 2022
SenseException
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we express that one cannot use matching() to alter the templated type of a Selectable, which means that it is OK to pass a Selectable of a type to a method that accepts a Selectable of a parent type.
The drawback is that it is no longer possible to use methods defined in Collection on an object that is returned by matching().