Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCOM-53: PhpParser doesn't ignore commented keywords #651

Closed
doctrinebot opened this issue May 24, 2011 · 3 comments
Closed

DCOM-53: PhpParser doesn't ignore commented keywords #651

doctrinebot opened this issue May 24, 2011 · 3 comments
Assignees
Labels

Comments

@doctrinebot
Copy link

Jira issue originally created by user mdhooge:

The PhpParser makes a too optimistic assumption about code convention...

If you have the word 'class' or 'interface' in the comment before the class definition, preg_match_all finds wrong slice of code and PHP complains with a Warning about "Unterminated comment". This occurs only once after the cache is cleared.

@doctrinebot
Copy link
Author

Comment created by @FabioBatSilva:

Hello all
I tested this issue.

After rewriting the php parser does not happen. : d274bd7

I think that can be closed

Thanks

@doctrinebot
Copy link
Author

Comment created by mdhooge:

Unfortunately, I can't remember when the problem disappeared but it is no longer here for sure.
And since the call to preg_match_all has been removed, we can close the issue.

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants