Skip to content

Loading…

DCOM-53: PhpParser doesn't ignore commented keywords #651

Closed
doctrinebot opened this Issue · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user mdhooge:

The PhpParser makes a too optimistic assumption about code convention...

If you have the word 'class' or 'interface' in the comment before the class definition, pregmatchall finds wrong slice of code and PHP complains with a Warning about "Unterminated comment". This occurs only once after the cache is cleared.

@doctrinebot

Comment created by @FabioBatSilva:

Hello all
I tested this issue.

After rewriting the php parser does not happen. : d274bd7

I think that can be closed

Thanks

@doctrinebot

Comment created by mdhooge:

Unfortunately, I can't remember when the problem disappeared but it is no longer here for sure.
And since the call to pregmatchall has been removed, we can close the issue.

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added the Bug label
@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.