Fix ProxyGenerator magic __set with void return type

[GameplayJDK]

See #917 for details.

[SenseException]

Please create a test that covers the bug behavior.

[SenseException]

This class is part of a different test and it should keep __set($n, $val) to cover cases where no types are used. Your case is already covered with MagicSetClassWithScalarTypeAndVoidReturnType.

[GameplayJDK]

I'll undo that change, but the __set() there should definitely have a scalar type in it's signature, otherwise the name of the test class is misleading. As I understood it, the MagicSetClass class does not have any type in its signature, while the MagicSetClassWithScalarType class does have a type in its signature, hence the name. So the MagicSetClassWithScalarTypeAndRenamedParameters should either be renamed to MagicSetClassWithRenamedParameters or have the type added, to make this consistent. But that could also be proposed in yet another PR, as it does not impact the changes introduced with this one.

[SenseException]

I don't know about the intention of the naming, so let's keep those names for now, while keeping the original state of this __set(). Your new test will cover the type.

[GameplayJDK]

Agreed. I'm going to revert this change now and hand in the PR for a re-review :)

[SenseException]

I'd prefer a second Doctrine reviewer who's taking a look at this. From my pov this looks good.

[malarzm]

Thanks @GameplayJDK!