Fix #922, ProxyGenerator missing assert #923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
while working on #917 I noticed a missing
assert()
in the methodgetParameterType()
of theProxyGenerator
.The
ReflectionParameter::getDeclaringFunction()
method returns aReflectionFunctionAbstract
, the type hint ofProxyGenerator::formatType(...)
isReflectionMethod
, one of two possible implementations, the other isReflectionFunction
.I'd propose a change from the above code to the code below:
3v4l.org snippet
Of course the assertion will always be true, but this theoretical type mismatch was pointed out by my IDE, which confused me at first. In my opinion this would make the code more clean and prevent any future confusion about what type is expected.