Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Fix Pull #62 error: ClassMetadataInfo::checkUp() - Embedded documents shouldn't have an id. #67

Merged
merged 1 commit into from Jun 22, 2013

Conversation

marnusw
Copy link
Contributor

@marnusw marnusw commented Jun 22, 2013

The ClassMetadataInfo:checkUp() method added in Pull #62 checked for the presence of an identifier but didn't exempt embedded documents.

The comment of this method is now more specific and ready to be extended with the details of additional future checks.

The exception message indicates that identifier refers to the @id field since this wasn't immediately apparent, and the name of the class producing the error is also included.

beberlei added a commit that referenced this pull request Jun 22, 2013
Fix Pull #62 error: ClassMetadataInfo::checkUp() - Embedded documents shouldn't have an id.
@beberlei beberlei merged commit 2041351 into doctrine:master Jun 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants