Removed doctrine/common from dependencies

The exception we were extending is deprecated.
doctrine · Jun 16, 2022 · 8e90bf2 · 8e90bf2
1 parent e2e084b
commit 8e90bf2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -6,6 +6,16 @@ awareness about deprecated code.
 - Use of our low-overhead runtime deprecation API, details:
   https://github.com/doctrine/deprecations/
 
+# Upgrade to 1.6
+
+## BC BREAK: `CircularReferenceException` no longer extends `Doctrine\Common\CommonException`
+
+We don't think anyone catches this exception in a `catch (CommonException)` statement.
+
+## `doctrine/data-fixtures` no longer requires `doctrine/common`
+
+If you rely on types from `doctrine/common`, you should require that package, regardless of whether other packages require it.
+
 # Between v1.0.0-ALPHA1 and v1.0.0-ALPHA2
 
 The FixtureInterface was changed from

diff --git a/composer.json b/composer.json
@@ -15,7 +15,6 @@
     ],
     "require": {
         "php": "^7.2 || ^8.0",
-        "doctrine/common": "^2.13|^3.0",
         "doctrine/persistence": "^1.3.3|^2.0|^3.0"
     },
     "conflict": {

diff --git a/lib/Doctrine/Common/DataFixtures/Exception/CircularReferenceException.php b/lib/Doctrine/Common/DataFixtures/Exception/CircularReferenceException.php
@@ -4,8 +4,8 @@
 
 namespace Doctrine\Common\DataFixtures\Exception;
 
-use Doctrine\Common\CommonException;
+use LogicException;
 
-class CircularReferenceException extends CommonException
+class CircularReferenceException extends LogicException
 {
-}
+}