Initial import of phpcr fixtures #10
Conversation
|
Why are you putting the Symfony DIC here ? this has nothing to do in a Doctrine project as there is no use of the Symfony2 DIC. Symfony extends the Loader to allow to inject the DIC when the fixtures implement ContaienrAwareInterface but it is not done by Doctrine itself: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/DoctrineAbstractBundle/Common/DataFixtures/Loader.php |
…the PHPCRFixtureInterface which is not needed anymore
|
Thank you for your comment, I was not aware of the Symfony extended Loader. The references to the Symfony DIC have been removed. |
…ly a copy of the MongoDBExecutor, modified the @author to reflect that + cleanup
|
looks good on a quick skim |
| namespace Doctrine\Common\DataFixtures\Purger; | ||
|
|
||
| use Doctrine\ODM\PHPCR\DocumentManager; | ||
| use Jackalope\Node; |
|
hi stof, does this make sense now, do you think you can merge it? |
| /** | ||
| * Delete all the nodes in the repository which are not prefixed with jcr: | ||
| */ | ||
| protected function deleteAllNodes() |
There was a problem hiding this comment.
I don't really see the need of an additional method for this.
|
@dbu I cannot merge it as I don't have access to the repo. I'm not even memeber of the Doctrine project. |
Initial import of phpcr fixtures
I have created a new "phpcr-fixtures" branch and implemented a Loader and Purger class for data fixtures based on PHPCR. We use it here at Liip to load fixtures in Jackalope.
Additionaly as our fixtures need to access the DIC, I have extended the FixtureInterface in PHPCRFixtureInterface so that we can inject the DIC from the Loader. I would be happy to change this is you have a better way to access the DIC from a FixtureInterface.