Demonstrate undefined index notice when using fixture dependent on ordered fixture. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brabeji
changed the title
| @@ -322,6 +322,10 @@ private function getUnsequencedClasses($sequences, $classes = null) | |||
| } | |||
|
|
|||
| foreach ($classes as $class) { | |||
| if(!isset($sequences[$class])) { | |||
| dump('UNDEFINED INDEX'); | |||
| die; | |||
There was a problem hiding this comment.
this should be removed, as it prevents merging the new test in the existing testsuite
There was a problem hiding this comment.
Unfortunately, without this check the notice is suppressed and the test passes. I am not sure why. This is rather demo than proper PR. Pls see the original comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates that undefined index notice gets somehow suppressed during standalone tests. That notice stops execution when running doctrine:fixtures:load which is a problem. Sorry about the whitespace formatting, relevant change is at the end of Loader.php diff.