doctrine/deprecations is a mandatory dependency #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Apr 3, 2023
derrabus
force-pushed
the
bugfix/deprecations-dependency
branch
from
8518539
to
1f6d67a
Compare
greg0ire
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We trigger deprecations from non-test classes and need the Doctrine deprecations library for that. Because of that, it has to be a mandatory dependency.
This change probably doesn't make that much of a difference because data fixtures is most likely used in projects that depend on other libraries that pull the
doctrine/deprecationsdependency already, like DBAL or ORM.