DBAL-17: E_STRICT error in Doctrine\DBAL\Driver\OCI8\Driver::_constructDsn()

[doctrinebot]

Jira issue originally created by user eriksencosta:

I get an E_STRICT error in Doctrine\DBAL\Driver\OCI8\Driver::_constructDsn() because I forgot to set a 'dbname' key in the params array to Doctrine\DBAL\DriverManager.

My Doctrine is a svn checkout, from 2.0.0-beta1 tag.

A patch is attached (patch -p0 < patch.diff on project root).

[doctrinebot]

Comment created by @beberlei:

is specifying the database name optional during connection to oracle databases? otherwise we could also throw an exception.

[doctrinebot]

Comment created by eriksencosta:

It's optional, according to http://php.net/oci_connect:

"If not specified, PHP uses environment variables such as TWO_TASK (on Linux) or LOCAL (on Windows) and ORACLE_SID to determine the Oracle instance to connect to."

I just spotted the error, I don't have an Oracle database neither the oci8 extension in my machine.

[doctrinebot]

Comment created by @beberlei:

fixed anyways

[doctrinebot]

Issue was closed with resolution "Fixed"

[doctrinebot]

Imported 1 attachments from Jira into https://gist.github.com/105e5b46f632c09fe007

• 10627_patch.diff

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.