New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBAL-577: AbstractPlatform::getInExpression calls non-existent method AbstractPlatform::getIdentifiers #1787
Comments
Comment created by heruan: I really don't see the meaning of AbstractPlatform::getIdentifiers.
which works perfectly fine without any need of calling a getIdentifiers method. |
Comment created by @beberlei: Code was removed, as it was a leftover from Doctrine 1.* times. |
Issue was closed with resolution "Fixed" |
Comment created by heruan: The whole getInExpression method was removed? How to build a IN-expression abstracting from platform now? The method worked, expect for a call to a non-existant AbstractPlatform::getIdentifiers. |
Comment created by @beberlei: The method did not work, because it was impossible to implement "getIdentifiers" at that point. You can build an IN expression by binding to a statement with "$statement->bindValue(1, $array, \Doctrine\DBAL\Connection::PARAM_INT_ARRAY);" or PARAM_STR_ARRAY. Alternatively you can do: implode(", ", array_map(array($connection, 'quote'), $values)); |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Jira issue originally created by user heruan:
The method AbstractPlatform::getInExpression($column, $values) still calls the non-existent method AbstractPlatform::getIdentifiers($values). This prevents the use of this method causing a brutal PHP failure. Why not pass the identifiers array instead of the values array, until the method is implemented?
The text was updated successfully, but these errors were encountered: