DBAL-802: Tablename quoting not working for ALTER TABLE

[doctrinebot]

Jira issue originally created by user dennisb:

I use the orm:schema-tool:update to update the database schema of my model which contains a table with the name "Character".
Quoting for this table name works without the need to add backticks in foreign key definitions (references Character) but "ALTER Character" misses the quotes.
The reason is that the getAlterTableSQL method of the MySqlPlatform class uses the name property of the supplied TableDiff which does not contain a quoted name.
The original Table information that contained the quoting information is not available from the TableDiff.

A quick fix is to just force a name quoting with "$this->quoteIdentifier($diff->name)" in the getAlterTableSQL but this does ignore all quoting-decision-functionality of doctrine.

[doctrinebot]

• duplicates DBAL-555: Table name is not quoted despite being a reserved word and being quoted in the annotation

[doctrinebot]

Comment created by dennisb:

Just checked on v2.4.2: the issue is still present there but the TableDiff now contains the original table information object so the fix may be a lot less hacky.

[doctrinebot]

Comment created by @deeky666:

[~dennisb] This issue should have been fixed in 2.5, commit: 75d35f5
See here: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php#L600

Please check again with the current master.

[doctrinebot]

Comment created by @deeky666:

Duplicate of http://www.doctrine-project.org/jira/browse/[DBAL-555](http://www.doctrine-project.org/jira/browse/DBAL-555)

[doctrinebot]

Issue was closed with resolution "Duplicate"

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.