Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger deprecation when configuring different versions #3757

Open
alcaeus opened this issue Nov 28, 2019 · 2 comments
Open

Trigger deprecation when configuring different versions #3757

alcaeus opened this issue Nov 28, 2019 · 2 comments

Comments

@alcaeus
Copy link
Member

alcaeus commented Nov 28, 2019

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

Initially suggested by @nicolas-grekas in symfony/recipes#693 (comment):

Actually, DoctrineBundle/DBAL could throw an exception when both settings are found but don't match (in DSN & config).

It is possible to configure two different server versions using DSN and config. This can affect driver selection and cause issues which are hard for users to debug. Therefor, I suggest treating this as an unsupported use-case in 3.0. To allow for a transition without BC breaks, 2.x should throw a deprecation warning in such cases, which can then be changed to an exception in 3.0.

This could theoretically expand to more settings that can be configured in DSN and configuration, but server_version was the one this came up with.

@nicolas-grekas
Copy link
Member

Oups sorry I meant this on driver and server_version mainly :)

@alcaeus alcaeus changed the title Trigger deprecation when configuring different character sets Trigger deprecation when configuring different versions Nov 28, 2019
@alcaeus
Copy link
Member Author

alcaeus commented Nov 28, 2019

Whoops. Need more ☕️ before doing this. I've updated the issue accordingly. That's what you get for choosing me as your secretary 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants