Prepare docs for Doctrine website #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2021
SenseException
requested changes
Oct 20, 2021
SenseException
approved these changes
Oct 20, 2021
TomHAnderson
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
I'm going to approve this for now. But there are a number of grammatical errors throughout the docs which should be corrected. I'm willing to do a PR on the docs as a follow-up to this PR to address them. I'm more concerned about getting this in place on the website.
Please create an issue, assigned to me, to review the docs' English as a follow-up to approving this PR.
|
If you want me to push a PR to this PR before you merge, I'm OK with that. I'll leave the decision for when to merge up to @driehle |
|
@TomHAnderson I'll merge this for now as this will likely enable me to render |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to doctrine/DoctrineModule#733, this PR prepares the docs for being rendered on the Doctrine website. The README has been split into multiple sections and converted from .md to .rst. A .doctrine-project.json is added.
Similar to and in line with: