Fix website configs build #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because doctrine/static-website-generator has a dependency to symfony/http-kernel that installs symfony/error-handler as a no-dev dependency, the Debug class is always available and enables Debug mode even in prod.
SenseException
force-pushed
the
fix-website-configs-build
branch
from
9047d3c
to
12c795f
Compare
greg0ire
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the website-configs build that broke after
Debug::enabled()was introduced in #346.Because doctrine/static-website-generator has a dependency to symfony/http-kernel, that installs symfony/error-handler as a no-dev dependency, the Debug class is always available and enables Debug mode even in prod.
I also adapted .github/workflows/website-configs.yml to start a build when the file itself was changed to make it possible to review this change (and also to ease future changes on this GA file).