This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
Dc 585 #1
Closed
Dc 585 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fields with alias were not added to the pendingFields array, the identifier fields of the table weren't added to the SELECT part of the query if they weren't present. Without an identifier field, Doctrine_Hydrator_Graph only returns one record.
With this fix the issue seems to be solved, and the tests are running ok. But right now I don't have here any huge application running doctrine... so I can't test the bugfix properly.
Hope this will help because it's an annoying issue, at least for me.
Thanks