This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
[DC-1037] Quote identifiers when getting/setting Migration version #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybr-nx
pushed a commit
to zone-eu/doctrine1
that referenced
this pull request
Mar 21, 2019
PHP 7.2 - deprecated "each" calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for ticket DC-1037:
http://www.doctrine-project.org/jira/browse/DC-1037
Without this patch, Migrations are fully broken for some databases (at least Oracle) when using quoted identifiers connection option.
This patch quotes identifiers used to generate raw SQL commands used in Doctrine_Migration.
I don't think this would present any type of backwards compatibility issues since we weren't quoting identifiers before, and there is no way to catch/modify the query before it is executed during the migration process.