Skip to content

Commit

Permalink
#615 - Refactoring test case to remove duplication
Browse files Browse the repository at this point in the history
  • Loading branch information
Ocramius committed Oct 19, 2014
1 parent 69494dc commit 264cd8e
Showing 1 changed file with 18 additions and 8 deletions.
26 changes: 18 additions & 8 deletions tests/Doctrine/Tests/ORM/Query/SqlWalkerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,36 @@
*/
class SqlWalkerTest extends OrmTestCase
{
/**
* @var SqlWalker
*/
private $sqlWalker;

/**
* {@inheritDoc}
*/
protected function setUp()
{
$this->sqlWalker = new SqlWalker(new Query($this->_getTestEntityManager()), new ParserResult(), array());
}

/**
* @dataProvider getColumnNamesAndSqlAliases
*/
public function testGetSQLTableAlias($tableName, $expectedAlias)
{
$query = new Query($this->_getTestEntityManager());
$sqlWalker = new SqlWalker($query, new ParserResult(), array());

$this->assertSame($expectedAlias, $sqlWalker->getSQLTableAlias($tableName));
$this->assertSame($expectedAlias, $this->sqlWalker->getSQLTableAlias($tableName));
}

/**
* @dataProvider getColumnNamesAndSqlAliases
*/
public function testGetSQLTableAliasIsSameForMultipleCalls($tableName)
{
$query = new Query($this->_getTestEntityManager());
$sqlWalker = new SqlWalker($query, new ParserResult(), array());

$this->assertSame($sqlWalker->getSQLTableAlias($tableName), $sqlWalker->getSQLTableAlias($tableName));
$this->assertSame(
$this->sqlWalker->getSQLTableAlias($tableName),
$this->sqlWalker->getSQLTableAlias($tableName)
);
}

/**
Expand Down

0 comments on commit 264cd8e

Please sign in to comment.