Skip to content

Loading…

DDC-1197: Proxies should handle variable argument lists #1802

Closed
doctrinebot opened this Issue · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This is a contingency issue for #60

"Fix to allow for proxy generated classes to respect methods in parent which may use funcgetargs internally. Previously they would be passed nothing and thus fail. Also reduces need to build up argumentString. "

@doctrinebot

Comment created by chrisrichard:

Could we use an annotation to indicate when a function uses variable arguments and output calluser_funcarray only in that case?

@doctrinebot

Comment created by @ocramius:

I won't fix this. There are some problems here that are not trivial:

1 - to make proxies always "safe", we would need to use func*get*args in every proxy call
2 - because of (1), performance will GREATLY degrade
3 - because of (1), byref parameter passing will be broken

What we could do is introspecting the contents of methods to look for func*get*args usages (requires introduction of a complex parser).

I am closing this - consider opening an issue at https://github.com/Ocramius/ProxyManager/issues instead, so we can analyze if this logic can be improved for 3.x with the replacement of the "simple" doctrine proxies with something more complete.

Also note that Ocramius/ProxyManager#159 could also solve this without the need for complex logic.

@doctrinebot

Issue was closed with resolution "Can't Fix"

@Ocramius Ocramius was assigned by doctrinebot
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.