Fix to ProxyFactory to respect parent methods which use func_get_args internally. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which may use func_get_args internally. Previously they would be passed nothing and thus fail. Also reduces need to build up argumentString.
|
Although strictly applied this patch is absolutely necessary we don't like the performance impact of it and are not merging it for this reason. Documentation will be updated that Entities / Documents are not allowed to have variable method signatures. |
|
I added a contingency ticket on Jira http://www.doctrine-project.org/jira/browse/DDC-1197 |
guilhermeblanco
added a commit
that referenced
this pull request
Jan 23, 2013
Fixing invalid XML mapping samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to allow for proxy generated classes to respect methods in parent which may use func_get_args internally. Previously they would be passed nothing and thus fail. Also reduces need to build up argumentString.