Allow the usage of embedded objects on parent classes. #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ClassMetadataInfo` was always using the "current class" to fetch the reflection of a property even when a field is declared on the parent class (which causes `ReflectionProperty` to throw an exception).
lcobucci
force-pushed
the
embeddable-and-inheritance
branch
from
1e8e42c
to
7f8a5f1
Compare
|
@Ocramius is this good enough? |
|
@lcobucci looks good, but can't merge atm (in a hurry) |
|
Don't worry was just checking if needed some more work ;) |
Ocramius
added a commit
that referenced
this pull request
Jun 19, 2016
Ocramius
added a commit
that referenced
this pull request
Jun 19, 2016
Ocramius
added a commit
that referenced
this pull request
Jun 19, 2016
Ocramius
added a commit
that referenced
this pull request
Jun 19, 2016
Ocramius
added a commit
that referenced
this pull request
Jun 19, 2016
|
@Ocramius Nice! Will inline the mapped classes on the next functional tests I may write. Thanks! |
alexgurrola
pushed a commit
to Sitetheory-Archive/doctrine2
that referenced
this pull request
Apr 13, 2017
…nto the test case
alexgurrola
pushed a commit
to Sitetheory-Archive/doctrine2
that referenced
this pull request
Apr 13, 2017
alexgurrola
pushed a commit
to Sitetheory-Archive/doctrine2
that referenced
this pull request
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClassMetadataInfowas always using the "current class" to fetch the reflection of a property even when a field is declared on the parent class (which causesReflectionPropertyto throw an exception).