[DDC-3467] Embedded on private fields in an inheritance don't work correctly #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3469 We use Jira to track the state of pull requests and the versions they got |
| @@ -0,0 +1,23 @@ | |||
| <?php | |||
| /** | |||
|
@Nemo64 is the idea not to see an exception? |
|
Maybe add a couple assertions on the actual metadata? |
Ocramius
changed the title
Ocramius
changed the title
Ocramius
changed the title
|
I ran into this issue today, @till the bug is that the variable is not accessible while it isn't in the child class. The embeddable should be in the parent and not the child. I can temporarily work around this by making it protected, but I'd rather avoid that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tried creating a test case for DDC-3467. I hope I put everything in the right place as my knowledge of this project is currently limited.