Fixed new instance creating for php 5.4+

[nkt]

No description provided.

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3158

We use Jira to track the state of pull requests and the versions they got
included in.

[tristanbes]

+1 The original error was :

__clone method called on non-object in ClassMetadataInfo.php line 872

[Ocramius]

We already had some bugs introduced by this hotfix (see #1051), so this needs more testing before it lands.

[nkt]

@Ocramius previous code hardcodes php versions, suggested changes just removes hardcoded versions.
newInstanceWithoutConstructor was added in 5.4.0 proof

[Ocramius]

@nkt yes, and I'm saying that using newInstanceWithoutConstructor already broke something.

[lavoiesl]

Rather than testing for version, you should test for the method itself as mentioned here : #1056 (comment)

[Majkl578]

OMG people, at least fifth PR with same change?

[stof]

Please read the discussion on 530c01b and you will see why we want to change the Doctrine behavior only on affected PHP version rather than on all PHP 5.4+. this change is breaking other stuff

[nkt]

@stof I don't really understand how this code could broke something?
Previous code is dirty hack:

$this->_prototype = unserialize(sprintf('O:%d:"%s":0:{}', strlen($this->name), $this->name))

No one promised that this code will works fine in future, and now it's broken.

This method should return new instance without calling costructor, so it's doing it.

[Ocramius]

No one promised that this code will works fine in future, and now it's broken.

It was a hack, and a well known one as well. It was used everywhere we needed to do this, and ReflectionClass#newInstanceWithoutConstructor was neglected because we had a good working solution for it. Turns out that ReflectionClass#newInstanceWithoutConstructor is not yet good enough, as it breaks anywhere you extend an internal class.

So yes, the hack is still more reliable than the official solution.

[nkt]

@Ocramius why it should break something, this is spited method, it's could working whatever it's want, but must return new instance of given class.
Can you show me any examples, where it broke something?

[Ocramius]

Here: http://3v4l.org/gGf7X

[nkt]

@Ocramius thanks. Now I see.
Can you release version with current fix?

[Ocramius]

@nkt it was already released

[nkt]

@Ocramius 👍
So I close it, maybe we should tell php-team fix this BC-break in next releases.

[stof]

there is already a discussion about this on php-internals