Add Changelog/Migration to 2.5 documentation chapter. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3516 We use Jira to track the state of pull requests and the versions they got |
| Most of the locations where previously only the ``Doctrine\ORM\EntityManager`` | ||
| was allowed are now changed to accept the ``EntityManagerInterface`` that was | ||
| introduced in 2.4. This allows you to more easily use the decorator pattern | ||
| to extend the EntityManager if you need. |
There was a problem hiding this comment.
I would be careful when saying this, because we still have lots of places where we pass $this to other objects, which is not compatible with decoration (the other objects receives the inner manager). And we cannot fix this in the current architecture
Update migration_2_5.rst
| Many of the locations where previously only the ``Doctrine\ORM\EntityManager`` | ||
| was allowed are now changed to accept the ``EntityManagerInterface`` that was | ||
| introduced in 2.4. This allows you to more easily use the decorator pattern | ||
| to extend the EntityManager if you need. It`s still not replaced everywhere, |
Ocramius
added a commit
that referenced
this pull request
Jan 20, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 20, 2015
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new chapter in documentation for migrating to 2.5. Includes a changelog of new features and improvements as well as BC breaks from UPGRADE.md
Are there any new features missing here? Missing BC breaks?