Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DDC-3719. #1399

Merged
merged 1 commit into from
Feb 16, 2016
Merged

Fix for DDC-3719. #1399

merged 1 commit into from
Feb 16, 2016

Conversation

boskee
Copy link
Contributor

@boskee boskee commented May 3, 2015

Switch to relationToTargetKeyColumns when matching non-owning side with Criteria. Fixes DDC-3719.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3723

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

@boskee can you please include a test case?

@TomasVotruba
Copy link
Contributor

I came across the same issue.

@Ocramius I could do that. Could you link me some example?

@TomasVotruba
Copy link
Contributor

Thanks. I've managed to fix that by using OneToMany annotation instead (which was the correct one).

I'll pass the tests back to @boskee .

@koemeet
Copy link

koemeet commented Jan 10, 2016

Is this PR stil being worked on?

@TomasVotruba
Copy link
Contributor

@steffenbrem Not really, I moved to another project a forgot about this.

@guilhermeblanco guilhermeblanco merged commit af2295b into doctrine:master Feb 16, 2016
@Ocramius Ocramius added this to the 2.6.0 milestone Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants