+ Index name for OneToOne relation #1498
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3883 We use Jira to track the state of pull requests and the versions they got |
| @@ -340,6 +340,7 @@ public function loadMetadataForClass($className, ClassMetadata $metadata) | |||
| $mapping['cascade'] = $oneToOneAnnot->cascade; | |||
| $mapping['orphanRemoval'] = $oneToOneAnnot->orphanRemoval; | |||
| $mapping['fetch'] = $this->getFetchMode($className, $oneToOneAnnot->fetch); | |||
| $mapping['indexName'] = $oneToOneAnnot->indexName; | |||
There was a problem hiding this comment.
I think the less we mess with implicit indexes the better - a better solution would be to define an @Index on the table that satisfies the FK index. Not sure if the TableDiff will prevent creation of the FK index if it's exactly satisfied by an explicit index though.
There was a problem hiding this comment.
@zeroedin-bill I disagree here. It's a lot easier and less error prone to have an attribute on the association simply for the index name. Also it relates a lot better to have it at this place rather than loosely in the table section. You can still do your own @Index definitions to overwrite implicit indexes if you want to. But simply being able to change the index name without having to clutter the definition with another @Index makes totally sense IMO.
No description provided.