Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to NonUniqueResultException #1575

Closed
wants to merge 0 commits into from

Conversation

Alfredao
Copy link
Contributor

@Alfredao Alfredao commented Dec 1, 2015

No description provided.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-4024

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

@Alfredao can you please add a minimal unit test for this? Although the code is brutally simple, it is still a requirement.

@Alfredao
Copy link
Contributor Author

Hello @Ocramius

Today a coworker asked me for help identifying what was wrong with his code. No error message was displayed. Then I realized that this was about this exception with no text message

As he is starting with Doctrine developmet, it could have been difficult for him to identify the problem by himself

This PR has been open for a long time. Will the merge be done? Is there anything that needs to be done yet?

Thank you!

@Ocramius Ocramius added this to the 2.6.0 milestone Jul 26, 2017
@Ocramius Ocramius self-assigned this Jul 26, 2017
@Ocramius
Copy link
Member

@Alfredao didn't see that tests were pushed: added milestone, will check it as soon as possible

@lcobucci
Copy link
Member

lcobucci commented Aug 6, 2017

@Alfredao @Ocramius I've rebased this branch but made a small mistake so I'm opening a new PR with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants