[DDC-1845] QuoteStrategy #372

FabioBatSilva · 2012-06-12T00:52:31Z

QuoteStrategy

http://www.doctrine-project.org/jira/browse/DDC-1845

This patch fix some quote problems using a default quote strategy and allows users find solutions themselves for weird quote cases.

This DBAL PR shoud be merged to fix sqlite tests in : doctrine/dbal#158

There is a lote of new method calls, the performance tests in sqlite are the following :

My branch :

. testSimpleQueryScalarHydrationPerformance10000Rows - 0.37292098999023 seconds
. testSimpleQueryArrayHydrationPerformance10000Rows - 0.50411009788513 seconds
. testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.1323919296265 seconds
. testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.0243051052094 seconds
. testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1673181056976 seconds
. testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.40403699874878 seconds
. testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.873291015625 seconds
. 99 CompanyContract: 0.023395
. 99 CompanyContract: 0.019528
. Memory usage before: 111715.53125 KB
. Memory usage after: 110282.875 KB
. Inserted 10000 objects in 5.5240259170532 seconds
. 100 CmsArticle findAll(): 0.018410
. 100 CmsArticle findAll(): 0.014157
. 100 CmsArticle find(): 0.043304
. 100 CmsArticle find(): 0.041451
. 100 CmsGroup: 0.009315
. 100 CmsGroup: 0.009239
. 100 CmsUser: 0.024051
. 100 CmsUser: 0.023655
. Compute ChangeSet 100 objects in 0.040482997894287 seconds

. Time: 19 seconds, Memory: 261.50Mb

Doctrine Master :

. testSimpleQueryScalarHydrationPerformance10000Rows - 0.37668490409851 seconds
. testSimpleQueryArrayHydrationPerformance10000Rows - 0.5009880065918 seconds
. testMixedQueryFetchJoinArrayHydrationPerformance10000Rows - 1.131824016571 seconds
. testSimpleQueryPartialObjectHydrationPerformance10000Rows - 1.037791967392 seconds
. testSimpleQueryFullObjectHydrationPerformance10000Rows - 4.1992859840393 seconds
. testMixedQueryFetchJoinPartialObjectHydrationPerformance2000Rows - 0.41158103942871 seconds
. testMixedQueryFetchJoinFullObjectHydrationPerformance2000Rows - 0.86575293540955 seconds
. 99 CompanyContract: 0.023206
. 99 CompanyContract: 0.020555
. Inserted 10000 objects in 5.4995818138123 seconds
. 100 CmsArticle findAll(): 0.018785
. 100 CmsArticle findAll(): 0.014160
. 100 CmsArticle find(): 0.042067
. 100 CmsArticle find(): 0.041076
. 100 CmsGroup: 0.009478
. 100 CmsGroup: 0.010591
. 100 CmsUser: 0.023727
. 100 CmsUser: 0.023073
. Compute ChangeSet 100 objects in 0.040009021759033 seconds

. Time: 19 seconds, Memory: 260.50Mb

travisbot · 2012-06-12T01:04:05Z

This pull request fails (merged c3eaf521 into 7b75849).

stof · 2012-06-12T06:50:52Z

lib/Doctrine/ORM/Configuration.php

+    public function getQuoteStrategy()
+    {
+        if ( ! isset($this->_attributes['quoteStrategy'])) {
+            $this->_attributes['quoteStrategy'] = new \Doctrine\ORM\Mapping\DefaultQuoteStrategy();


you should add a use statement

@FabioBatSilva you forgot this one ;)

FabioBatSilva · 2012-06-12T13:01:49Z

DONE !!!

Thanks @stof

travisbot · 2012-06-12T13:35:39Z

This pull request fails (merged 80ef4c1e into 7b75849).

stof · 2012-06-12T13:41:09Z

please fix the code for PostgreSQL and SQLite

Ocramius · 2012-06-12T13:57:26Z

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

                if (empty($joinColumn['referencedColumnName'])) {
                    $joinColumn['referencedColumnName'] = $this->namingStrategy->referenceColumnName();
                }
+
+                if ($joinColumn['name'][0] == '`') {
+                    $joinColumn['name']   = trim($joinColumn['name'], '`');


This is obviously for MySQL: are there other engines using different characters for quoting identifiers?

hi @Ocramius

This is just a doctrine quote token, not used in SQL level

FabioBatSilva · 2012-06-12T14:01:18Z

Hi @stof

already is fixed.

PostgreSQL fails on cache, even in doctrine/master. not related with my patch.
To fix SQLite doctrine/dbal#158 shoud be merged.

travisbot · 2012-06-12T21:07:38Z

This pull request fails (merged 3d4404dc into 7b75849).

travisbot · 2012-06-15T15:38:31Z

This pull request fails (merged 0ce06e2b into 27b4f58).

beberlei · 2012-06-18T14:20:06Z

+1 from me, @guilhermeblanco whats your take?

guilhermeblanco · 2012-06-18T14:49:30Z

lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php

-                        $class->getTableName() . '_' . $class->columnNames[$class->identifier[0]] . '_seq' :
-                        null;
-                $class->setIdGenerator(new \Doctrine\ORM\Id\IdentityGenerator($seqName));
+                $sequenceName = null;


Missing line break between assignment and control structure

travisbot · 2012-06-18T17:45:16Z

This pull request fails (merged 039c23ad into 41d9f61).

travisbot · 2012-06-18T17:49:52Z

This pull request fails (merged b9d94e7 into 41d9f61).

FabioBatSilva · 2012-06-18T18:36:07Z

Hi @guilhermeblanco,

Fixed !!
Please take a look again

Thanks

travisbot · 2012-06-18T18:40:06Z

This pull request fails (merged 65efda4 into 41d9f61).

travisbot · 2012-06-18T18:45:08Z

This pull request fails (merged 7800a7e into 41d9f61).

guilhermeblanco · 2012-06-22T05:58:36Z

lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php

-                $class->setIdGenerator(new \Doctrine\ORM\Id\IdentityGenerator($seqName));
+                $sequenceName = null;
+
+                if($this->targetPlatform instanceof Platforms\PostgreSQLPlatform) {


Missing space between if and open parenthesis

travisbot · 2012-06-23T18:29:45Z

This pull request fails (merged ca4862a into 41d9f61).

FabioBatSilva · 2012-06-23T19:13:18Z

DONE !!!

Ocramius · 2012-06-23T19:18:27Z

@FabioBatSilva are the failures now caused by the PR? They're not matching the ones I used to see on PostgreSQL...

FabioBatSilva · 2012-06-23T19:28:00Z

Hi @Ocramius

PostgreSQL fails on cache, even in doctrine/master. not related with my patch.
To fix SQLite doctrine/dbal#158 shoud be merged.

Thanks .

Ocramius · 2012-06-23T21:29:36Z

good to know =)

[DDC-1845] QuoteStrategy

stof reviewed Jun 12, 2012
View reviewed changes

Ocramius reviewed Jun 12, 2012
View reviewed changes

guilhermeblanco reviewed Jun 18, 2012
View reviewed changes

FabioBatSilva added 5 commits June 18, 2012 14:43

change quote strategy to interface

85b6f8d

revert wrong change

ea69048

revert submodule change

ab9ff81

Fix CS and test configuration

49f9d18

add DefaultQuoteStrategy use statement

b9d94e7

FabioBatSilva added 2 commits June 18, 2012 15:24

Fix CS

65efda4

wrong indentation

7800a7e

guilhermeblanco reviewed Jun 22, 2012
View reviewed changes

Fix CS

ca4862a

guilhermeblanco added a commit that referenced this pull request Jun 25, 2012

Merge pull request #372 from FabioBatSilva/DDC-1845

cb72219

[DDC-1845] QuoteStrategy

guilhermeblanco merged commit cb72219 into doctrine:master Jun 25, 2012

FabioBatSilva deleted the DDC-1845 branch January 18, 2013 00:26

This was referenced Dec 6, 2015

DDC-1870: [GH-372] [DDC-1845] QuoteStrategy #2533

Closed

DDC-1885: Problem with column quoting on Delete #2549

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DDC-1845] QuoteStrategy #372

[DDC-1845] QuoteStrategy #372

FabioBatSilva commented Jun 12, 2012

travisbot commented Jun 12, 2012

stof Jun 12, 2012

Ocramius Jun 12, 2012

FabioBatSilva Jun 12, 2012

FabioBatSilva commented Jun 12, 2012

travisbot commented Jun 12, 2012

stof commented Jun 12, 2012

Ocramius Jun 12, 2012

FabioBatSilva Jun 12, 2012

FabioBatSilva commented Jun 12, 2012

travisbot commented Jun 12, 2012

travisbot commented Jun 15, 2012

beberlei commented Jun 18, 2012

guilhermeblanco Jun 18, 2012

travisbot commented Jun 18, 2012

travisbot commented Jun 18, 2012

FabioBatSilva commented Jun 18, 2012

travisbot commented Jun 18, 2012

travisbot commented Jun 18, 2012

guilhermeblanco Jun 22, 2012

travisbot commented Jun 23, 2012

FabioBatSilva commented Jun 23, 2012

Ocramius commented Jun 23, 2012

FabioBatSilva commented Jun 23, 2012

Ocramius commented Jun 23, 2012

[DDC-1845] QuoteStrategy #372

[DDC-1845] QuoteStrategy #372

Conversation

FabioBatSilva commented Jun 12, 2012

QuoteStrategy

My branch :

Doctrine Master :

travisbot commented Jun 12, 2012

stof Jun 12, 2012

Choose a reason for hiding this comment

Ocramius Jun 12, 2012

Choose a reason for hiding this comment

FabioBatSilva Jun 12, 2012

Choose a reason for hiding this comment

FabioBatSilva commented Jun 12, 2012

travisbot commented Jun 12, 2012

stof commented Jun 12, 2012

Ocramius Jun 12, 2012

Choose a reason for hiding this comment

FabioBatSilva Jun 12, 2012

Choose a reason for hiding this comment

FabioBatSilva commented Jun 12, 2012

travisbot commented Jun 12, 2012

travisbot commented Jun 15, 2012

beberlei commented Jun 18, 2012

guilhermeblanco Jun 18, 2012

Choose a reason for hiding this comment

travisbot commented Jun 18, 2012

travisbot commented Jun 18, 2012

FabioBatSilva commented Jun 18, 2012

travisbot commented Jun 18, 2012

travisbot commented Jun 18, 2012

guilhermeblanco Jun 22, 2012

Choose a reason for hiding this comment

travisbot commented Jun 23, 2012

FabioBatSilva commented Jun 23, 2012

Ocramius commented Jun 23, 2012

FabioBatSilva commented Jun 23, 2012

Ocramius commented Jun 23, 2012