Changed commands to use command.name in the help #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stof: this may need to have the required versions of SF2 console bumped, no? |
|
@Ocramius No, this feature is already available in 2.0: https://github.com/symfony/Console/blob/2.0/Command/Command.php#L447 |
|
Aha, thought you did the PR because of some improvement :) thx |
|
The improvement will be possible thanks to this change. See my comment on the dbal PR :) |
guilhermeblanco
added a commit
that referenced
this pull request
Jul 23, 2012
Changed commands to use command.name in the help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code does not work for child classes: it gets the name too early as the child has not changed it yet at this point. using
%command;name%replaces it only when the help needs to be displayed.This is similar to doctrine/dbal#174