Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the setCustomHydrationMode function #424

Closed
wants to merge 3 commits into from
Closed

Create the setCustomHydrationMode function #424

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8ff7ce
Create the setCustomHydrationMode function
Aug 14, 2012
56041e4
Pluralise function name
Aug 14, 2012
0b61401
Fixup syntax error + reset hydration modes
Aug 14, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/Doctrine/ORM/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,18 @@ public function setCustomDatetimeFunctions(array $functions)
}
}

/**
* Set the custom hydrator modes in one pass.
*
* @param array An array of ($modeName => $hydrator)
*/
public function setCustomHydrationMode($modes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method should have plural name if you set multiple names

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

{
foreach ($modes as $modeName, $hydrator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reset the Hydration modes here eventually. Otherwise rename the method to addCustomHydrationModes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error?

$this->addCustomHydrationMode($modeName, $hydrator);
}
}

/**
* Get the hydrator class for the given hydration mode name.
*
Expand Down