Fixes bug whereby orphan-removal value in XMLDriver is incorrectly parsed as true #473

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

I realise this is very hand wavy and if you require some more information or test cases then I can see about that.

However, just to get the issue logged, as I just spent 3 hours reverse engineering the doctrine code to find this, and it may help someone else.

Basically when reading the XML mapping data from generated XML files the orphan-removal value was being incorrectly parse as 'true' when it was set to 'false' in the mapping file.

I think this is because the XML parser was parsing the attribute as an object and when it was casted a boolean this meant the value became true. To overcome this I first cast the value as a string, and then to a bool.

Let me know if you need more information.

Thanks.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2067

Member

stof commented Oct 11, 2012

Please add a test case for this to avoid regressions (btw, I'm not sure this fix is valid)

Owner

beberlei commented Nov 12, 2012

This was fixed already.

@beberlei beberlei closed this Nov 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment