[DDC 2004] addFilter class name or instance #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouples ER implementation from EM, as it should be.
…interface, not ORM class.
…ment to 5.3.9. Changed to reflection approach which still keep us at the same dependency as before.
[2.3] Use HelperSet in cli-config.php
… field to null explicitly to override possible previous values.
[DDC-1961] Fixed parameter type support in Parameter
…() method instead of having to implement themselves.
This allows multiple hydrators to be set at once, and also allows for the customHydrationMode options to be set via DoctrineORMModule
Added the lines suggested by the original reporter.
…espaces from top PEAR directory
…ObjectManagerAware. I ran into that problem while I had two objects in the identitymap while hydrating a collection: one was new a "real" entity and the other one was an uninitialized proxy. For "real" entities the em is injected in line 2427, for new entities it is injected in 2436->2364, but for proxies this is missing. According to the comment "inject ObjectManager into just loaded proxies." the code in line 2427 should do this, but in fact it is just used if it is a "real" entity or an already initialized proxy. Moving the injection to outside of the condition in line 2411 (if the entity is an unitialized proxy) solves this.
Restored old way of injection to just inject it during a refresh Added injection for initialized proxies
… foreign identifier.
…teger, causing inconsistency with the string handling.
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
all ready in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to add filter class name or instance to addFilter. This is useful to use services to inject other dependencies.