Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined index for discriminator column length attribute in SchemaTool #5798

Closed
wants to merge 1 commit into from
Closed

Fix undefined index for discriminator column length attribute in SchemaTool #5798

wants to merge 1 commit into from

Conversation

sergeyfedotov
Copy link
Contributor

No description provided.

@Ma27
Copy link
Contributor

Ma27 commented Jan 8, 2017

👍

@Ocramius Ocramius self-requested a review January 8, 2017 14:13
@Ocramius Ocramius self-assigned this Jan 8, 2017
@Ocramius Ocramius added the Bug label Jan 8, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Jan 8, 2017
@Ocramius Ocramius modified the milestones: 2.5.7, 2.6.0 Jun 21, 2017
Ocramius added a commit that referenced this pull request Jun 21, 2017
@Ocramius Ocramius closed this in 98aa25b Jun 21, 2017
@Ocramius
Copy link
Member

@sergeyfedotov sorry for the huge wait: this has been merged into master and 2.5

Thanks for your patch: it was pretty much pristine - it wasn't considered "merged" because I manually rebased it before merging.

@Ocramius
Copy link
Member

master: 98aa25b
2.5: 1d1de7d

@dengm129
Copy link

master:98aa25b
2.5:1d1de7d

@sergeyfedotov sergeyfedotov deleted the fix-discriminator-column-missing-length branch July 8, 2017 10:54
@Ocramius Ocramius changed the title Fix undefined index for discriminator column in SchemaTool Fix undefined index for discriminator column length attribute in SchemaTool Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants