Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated enum type comment from declaration. #6089

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

damour
Copy link
Contributor

@damour damour commented Oct 18, 2016

Diff command generate duplicated comment declaration:
ALTER TABLE test CHANGE type type ENUM('enabled', 'disabled', 'bonus', 'jackpot') COMMENT '(DC2Type:enum_status)' NOT NULL COMMENT '(DC2Type:enum_status)''

@Ocramius
Copy link
Member

@damour seems good, but can you please also add a requiresSQLCommentHint that always returns true please?

@damour
Copy link
Contributor Author

damour commented Oct 21, 2016

@Ocramius done, thanks.

@Ocramius Ocramius added this to the 2.6.0 milestone Oct 25, 2016
@Ocramius Ocramius self-assigned this Oct 25, 2016
@Ocramius
Copy link
Member

@damour thanks!

@Ocramius Ocramius merged commit cf1ba31 into doctrine:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants