[DX] Add details about invalid Connection passed at creation of EntityManager. #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Nov 17, 2016
| @@ -860,7 +860,7 @@ protected static function createConnection($connection, Configuration $config, E | |||
| } | |||
|
|
|||
| if ( ! $connection instanceof Connection) { | |||
| throw new \InvalidArgumentException("Invalid argument: " . $connection); | |||
| throw new \InvalidArgumentException(sprintf('Invalid argument for connection "%s".', is_object($connection) ? get_class($connection) : gettype($connection) . '#' . $connection)); | |||
There was a problem hiding this comment.
The # is confusing in my opinion. The message should probably be 'Invalid $connection argument of type %s given: "%s"'
Ocramius
suggested changes
Nov 17, 2016
| @@ -204,4 +207,15 @@ public function transactionalCallback($em) | |||
| $this->assertSame($this->_em, $em); | |||
| return 'callback'; | |||
| } | |||
|
|
|||
| /** | |||
| * @expectedException \InvalidArgumentException | |||
There was a problem hiding this comment.
Please use $this->expectExceptionMessage() and $this->expectException() instead of the annotation
There was a problem hiding this comment.
fine by me to change, but setExpectedException has been deprecated on PHPUnit
(for ref.: sebastianbergmann/phpunit#2074 (comment))
There was a problem hiding this comment.
@SpacePossum then the new API. We can bump the required PHPUnit version without any issues 👍
|
@SpacePossum 👍 merged, thanks a lot! |
Ocramius
added a commit
that referenced
this pull request
Nov 18, 2016
|
thanks @Ocramius 👍 :) |
SpacePossum
deleted the
master_EntityManager_exception_details_on_connection_fail
branch
yvoyer
pushed a commit
to yvoyer/doctrine2
that referenced
this pull request
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.