Fix getSQLTableAlias for postgre camelized table name #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In postgreSQL with old databases we can have camelized model names to query on we need to add quote around the table name like : ``` * @Orm\Table(name="""someThing""") ``` But when query is built the alias taken will be `"` this fix will find the good alias to use enabling to query camelized tables
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
| @@ -284,7 +284,9 @@ public function getSQLTableAlias($tableName, $dqlAlias = '') | |||
| $tableName .= ($dqlAlias) ? '@[' . $dqlAlias . ']' : ''; | |||
|
|
|||
| if ( ! isset($this->tableAliasMap[$tableName])) { | |||
| $this->tableAliasMap[$tableName] = strtolower(substr($tableName, 0, 1)) . $this->tableAliasCounter++ . '_'; | |||
| $prefix = (substr($tableName, 0, 1) != "\"") ? substr($tableName, 0, 1) : substr($tableName, 1, 1); | |||
There was a problem hiding this comment.
And you removed strtolower, which broke tests.
|
By the way, this PR collides with another one: #615 (which would also solve this issue in different, IMO cleaner way). |
|
Yes #615 should work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In postgreSQL with old databases we can have camelized model names to query on we need to add quote around the table name like :
But when query is built the alias taken will be
"this fix will find the good alias to use enabling to query camelized tables