Fix wrong variable name #6356
Closed
Fix wrong variable name #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix $fieldMapping to $embeddedClass in generateEmbeddedPropertyDocBlock
|
I am a lama in tests. I'm giving a fix, maybe someone else will do the tests? |
|
@gander you just need to create an example that touches this code path - use existing tests as example 👍 |
|
@Ocramius, I tried to do these unit tests, but they are terribly complicated and I do not know what to duplicate. It is still too difficult for me :( |
|
@gander how did you reach the issue? Don't you have some code that triggered the problem? |
astepin
added a commit
to astepin/doctrine2
that referenced
this pull request
Jun 8, 2017
astepin
added a commit
to astepin/doctrine2
that referenced
this pull request
Jun 9, 2017
|
Closing in favor of #6494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix $fieldMapping to $embeddedClass in generateEmbeddedPropertyDocBlock
#6314