Fix quoting issues related to ticket #6402 #6404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply quoting strategy to foreign key columns of one-to-one relation so that correct select statements are generated. And use unquoted column names in result mapping instead of quoted ones, as consumers (namely IdentifierFlattener) expect unquoted column names.
|
Is there any way to rerun the Travis CI build? The mariadb problem looks to me like a transient error. |
|
@lemartin restarted, I'll also review your PR in a few hours 😉 |
lcobucci
suggested changes
Apr 24, 2017
| <?php | ||
|
|
||
|
|
||
| namespace Doctrine\Tests\ORM\Functional; |
There was a problem hiding this comment.
Please move this test to Doctrine\Tests\ORM\Functional\Ticket
| use Doctrine\Tests\Models\Quote\User; | ||
| use Doctrine\Tests\OrmFunctionalTestCase; | ||
|
|
||
| class QuoteTest extends OrmFunctionalTestCase |
There was a problem hiding this comment.
Please refer to the ticket on the class name (e.g. GH6402Test) also adding the PHPUnit's @group 6402 to the class docblock
|
|
||
| return $address->id; | ||
| } | ||
| } |
phansys
suggested changes
Apr 24, 2017
| @@ -1327,7 +1327,7 @@ protected function getSelectColumnAssociationSQL($field, $assoc, ClassMetadata $ | |||
| $resultColumnName = $this->getSQLColumnAlias($joinColumn['name']); | |||
| $type = PersisterHelper::getTypeOfColumn($joinColumn['referencedColumnName'], $targetClass, $this->em); | |||
|
|
|||
| $this->currentPersisterContext->rsm->addMetaResult($alias, $resultColumnName, $quotedColumn, $isIdentifier, $type); | |||
| $this->currentPersisterContext->rsm->addMetaResult($alias, $resultColumnName, $joinColumn["name"], $isIdentifier, $type); | |||
There was a problem hiding this comment.
Please, use single quotes.
phansys
approved these changes
Apr 24, 2017
|
Thanks for the reviews, sorry for spamming Travis. |
|
@lemartin manually merged on 7c6c5d8 talking with @Ocramius we decided to keep in |
|
Handled in #6416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply quoting strategy to foreign key columns of one-to-one relation so
that correct select statements are generated. And use unquoted column
names in result mapping instead of quoted ones, as consumers (namely
IdentifierFlattener) expect unquoted column names.