Fix quoting when using inheritance as well #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
commented
Apr 30, 2017
| * @param string $type | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function getSelectJoinColumnSQL($tableAlias, $joinColumnName, $type) | ||
| protected function getSelectJoinColumnSQL($tableAlias, $joinColumnName, $quotedColumnName, $type) |
There was a problem hiding this comment.
Theoretically this is as minor BC break, should we add to UPGRADING.md?
There was a problem hiding this comment.
Not a valid BC break since we do not allow custom persisters.
In order to keep that information for inheritance mapping.
lcobucci
force-pushed
the
fix-quote-on-inheritance
branch
from
c869347
to
0aef63b
Compare
|
|
|
@guilhermeblanco just a note: rebasing on this will likely be annoying. Still, the fix is valid IMO, and it shall be merged in |
Ocramius
approved these changes
May 2, 2017
| * @param string $type | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function getSelectJoinColumnSQL($tableAlias, $joinColumnName, $type) | ||
| protected function getSelectJoinColumnSQL($tableAlias, $joinColumnName, $quotedColumnName, $type) |
This was referenced May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6402 and #6404