Update QueryBuilder docblock to reflect correct type of bound parameter type #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
suggested changes
May 23, 2017
lib/Doctrine/ORM/QueryBuilder.php
Outdated
| @@ -526,7 +526,7 @@ public function getRootEntities() | |||
| * | |||
| * @param string|integer $key The parameter position or name. | |||
| * @param mixed $value The parameter value. | |||
| * @param string|null $type PDO::PARAM_* or \Doctrine\DBAL\Types\Type::* constant | |||
| * @param mixed|null $type PDO::PARAM_* or \Doctrine\DBAL\Types\Type::* constant | |||
There was a problem hiding this comment.
Can you use string|integer|null instead? mixed is a bit too broad
Hello, thank you very much for your work, it's awesome! I found a minor error in PHPDOC for method setParameter. Argument "type" can be a string or null but can be also an int if it comes from \PDO::PARAM_*. So I've changed typehint "string" into "mixed".
lcobucci
approved these changes
May 23, 2017
|
@fmagnan awesome! 🚢 |
Ocramius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
thank you very much for your work, it's awesome!
I found a minor error in PHPDOC for method setParameter. Argument "type" can be a string or null but can be also an int if it comes from \PDO::PARAM_*. So I've changed typehint "string" into "mixed".