Update ConsoleRunner's command list to include L2 cache and DBAL reserved keywords commands

[lcobucci]

These commands were missing and they're quite important...

[Ocramius]

@lcobucci can we add a test checking the list of registered commands? Or is the console runner untestable?

[lcobucci]

@Ocramius we can add an assertion like (for each command):

self::assertTrue($app->has('dbal:run-sql'));

or:

self::assertTrue($app->has((new \Doctrine\DBAL\Tools\Console\Command\RunSqlCommand())->getName()));

Maybe we can move the list of classes to a constant and reuse that constant to instantiate them and test things, like:

foreach (ConsoleRunner::COMMAND_LIST as $command) {
    self::assertTrue($app->has((new $command())->getName()));
}

What do you prefer?

[Ocramius]

The first one: ensures BC and we see the diff immediately if something changes

…

On 22 Jul 2017 01:54, "Luís Cobucci" ***@***.***> wrote: @Ocramius <https://github.com/ocramius> we can add an assertion like (for each command): self::assertTrue($app->has('dbal:run-sql')); or: self::assertTrue($app->has((new \Doctrine\DBAL\Tools\Console\Command\RunSqlCommand())->getName())); Maybe we can move the list of classes to a constant and reuse that constant to instantiate them and test things, like: foreach (ConsoleRunner::COMMAND_LIST as $command) { self::assertTrue($app->has((new $command())->getName()));} What do you prefer? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6556 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakAPcuBai8PpV5YJeCw5FQ3_CgSd3ks5sQTougaJpZM4OZbPJ> .

[Ocramius]

LGTM 🚢