Add Type::GUID to $typeAlias list in EntityGenerator #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JKapitein, thanks for your contribution! Would you mine to go a bit deeper and provide a unit test for this change? It would be awesome! Thanks! |
|
I've added the test. I ran it, and it passed with the type alias set and failed without it. |
Right now, when generating entities, a column of type 'guid' will generate the following PHPDoc: ``` /** * Get id * * @return guid */ public function getId() {...} ``` Since guid is not a valid PHP type, this throws a warning in PHPStorm, and I assume most IDEs. Adding the type to the type alias list fixes the problem.
lcobucci
approved these changes
Nov 27, 2017
|
@JKapitein 🚢 it will be available on our next minor release. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when generating entities, a column of type 'guid' will generate the following PHPDoc:
Since guid is not a valid PHP type, this throws a warning in PHPStorm, and I assume most IDEs.
Adding the type to the type alias list fixes the problem.