-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS] Ported lib/ to updated CS 2.0 #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I may add: "argh". |
@Ocramius I'd like to merge this today so it doesn't block @guilhermeblanco's work and other PRs. Will happily address any post-merge review anytime later (it's master-only after all). Are you ok with that? |
Ocramius
approved these changes
Jan 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beware, tons of changes. Most of them automatically fixed by phpcbf.
Most of the changes should be harmless except some weak->strict comparison changes (one was kept because juggling is part of expected behavior (really), hopefully we can eliminate it later by explicit casts).
Disabled:
Tried to narrow down as many iterables and mixeds as possible (manually), but it's still a mixed land more than I'd like. (Whoever invented wide
array
type in phpDoc standard killed some kittens btw.)Made lib/ check mandatory on CI (although now irrelevant until we fix CI).
https://travis-ci.org/doctrine/doctrine2/jobs/325277840
∑ 3,599 additions, 7,202 deletions.
Future scope: